Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add content for WebTransport #198

Merged
merged 11 commits into from
Oct 12, 2022
Merged

Add content for WebTransport #198

merged 11 commits into from
Oct 12, 2022

Conversation

salmad3
Copy link
Member

@salmad3 salmad3 commented Sep 21, 2022

Context

Latest preview

Please view the latest Fleek preview here.

Uses build preview from previous PR as CI unavailable

@salmad3 salmad3 added the ready for review PR is ready for review label Sep 21, 2022
@salmad3 salmad3 linked an issue Sep 26, 2022 that may be closed by this pull request
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
@salmad3
Copy link
Member Author

salmad3 commented Sep 29, 2022

To fix merge conflicts when QUIC content is finalized

Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
@salmad3
Copy link
Member Author

salmad3 commented Oct 4, 2022

@marten-seemann checking if there are any other parts to reconsider

content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
Co-authored-by: Marco Munizaga <marco@marcopolo.io>
@salmad3 salmad3 added change request PR requires changes. ready for review PR is ready for review and removed ready for review PR is ready for review change request PR requires changes. labels Oct 8, 2022
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR target master now?

content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
content/concepts/transport.md Outdated Show resolved Hide resolved
@salmad3 salmad3 changed the base branch from transport/quic to master October 12, 2022 09:30
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DannyS03 Thank you for your work on this!

This LGTM, module one suggestion.

content/concepts/transport.md Outdated Show resolved Hide resolved
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
@salmad3 salmad3 merged commit 60db134 into master Oct 12, 2022
@salmad3 salmad3 removed the ready for review PR is ready for review label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add WebTransport to transport documentation
3 participants