fix: better clarity #367
Merged
fix: better clarity #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I interpreted the story differently, as in, I thought there were four participants here: me, QmAlice, QmBob, and QmRelay. `I have a peer with the Peer ID QmAlice` meant `I have a friend with Peer ID QmAlice` to me in the first place.
|
How about: "I have a libp2p node with a Peer ID...". |
@Stebalien Sounds good, that's even clearer. |
Stebalien
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I interpreted the story differently, as in, I thought there were four participants here: me, QmAlice, QmBob, and QmRelay.
I have a peer with the Peer ID QmAlicemeantI have a friend with Peer ID QmAliceto me in the first place.Or the other way around,
I want to give out my addresscan be changed toI want to give out my address of QmAlice, which may seem verbose.