circuitv2: fix resource accounting when connection upgrading fails

[marten-seemann]

Very similar to #2015.

[MarcoPolo]

you mean #2025 ?

[MarcoPolo]

Where is the missing connScope.Done call?

[marten-seemann]

Where is the missing connScope.Done call?

Here:

go-libp2p/p2p/protocol/circuitv2/client/transport.go

Lines 66 to 69 in 34dc115

	cc, err := c.upgrader.Upgrade(ctx, c, conn, network.DirOutbound, p, connScope)
	if err != nil {
	return nil, err
	}