swarm: use shared black hole filters for autonat #2561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
sukun/autonat-v2-2
branch
2 times, most recently
from
e080d99 to
af0ac51
Compare
sukunrt
force-pushed
the
sukun/autonat-v2-2
branch
5 times, most recently
from
3ff9598 to
a3138cf
Compare
|
Merging this in to the main PR #2422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sharing the black hole filters and added a ReadOnly mode to black hole detector where the detector doesn't update the state of the individual filters. This ReadOnly mode is used in the AutoNAT(both v1 and v2) swarms. This looks like the nicest option.