debug interop failure #2588
Closed
debug interop failure #2588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
sukun/webrtc-debug-interop
branch
from
6bdaa7d to
3c0bc21
Compare
sukunrt
force-pushed
the
sukun/webrtc-debug-interop
branch
from
a0bf064 to
d9741d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exact issue:
Chrome -> go-libp2p: PING
Chrome -> go-libp2p: CloseWrite(FIN)
go-libp2p reads PING
go-libp2p -> Chrome: PING
go-libp2p reads FIN
go-libp2p closes data channel
Now there is a race between onMessage event handler on chrome and onClose event handler on chrome. Depending on what’s fired first the test succeeds or fails.