Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: testing https://github.com/pl-strflt/uci/pull/53 [DO NOT MERGE] #2603

Closed
wants to merge 8 commits into from
Closed

chore: testing https://github.com/pl-strflt/uci/pull/53 [DO NOT MERGE] #2603

wants to merge 8 commits into from

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Oct 12, 2023 •
edited
Loading

TODO:

  • test case when PR changes protoc versions in comments
  • test case when the new workflow param is not provided
  • test case when the new workflow param is false

@galargh galargh mentioned this pull request Oct 13, 2023
Merged
@marten-seemann
Copy link
Contributor

We have this is on master now. Thank you @galargh for resolving yet another pain point!

@galargh galargh deleted the testing-go-gen-protoc-versions-ignore branch December 1, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galargh @marten-seemann