fix(tcpreuse): remove windows specific code #3039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need to debug the failing test still |
|
just an incomplete read in the test. Not a real issue. |
MarcoPolo
force-pushed
the
marco/tcpreuse-windows
branch
from
332f113 to
5d36189
Compare
MarcoPolo
changed the title
Unclear why, but this causes a lot of CPU usage according to @aschmahmann
MarcoPolo
force-pushed
the
marco/tcpreuse-windows
branch
from
5d36189 to
cfa8b3b
Compare
|
Merging since this may be related to the test failures in #3036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unclear why, but this causes a lot of CPU usage according to @aschmahmann
I wonder if we are spinning in the for loop. Is it possible the Windows api returns no bytes read and no error?