swarm: record conn metrics only once #3091
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
changed the title
sukunrt
force-pushed
the
sukun/swarm-metrics
branch
from
5e679d4 to
5a4f640
Compare
This causes discrepancy when the connection is closed before being added to the swarm. This happens only in dial_worker loop when adding to the swarm fails. It's nicer to fix this with a once than to ensure that Close is never called twice within the swarm.
sukunrt
force-pushed
the
sukun/swarm-metrics
branch
from
5a4f640 to
e1565ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes discrepancy when the connection is closed before being added to the swarm. This happens only in dial_worker loop when adding to the swarm fails. It's nicer to fix this with a once than to ensure that Close is never called twice within the swarm.
Previously, we did something similar here for tcp connection metrics:
https://github.com/libp2p/go-libp2p/pull/2953/files