-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: convert to monorepo #1792
Conversation
dbbbeb0
to
ef76b7a
Compare
a5988c5
to
6540471
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this! Will hopefully improve both DX and release management 🥳 I left some comments.
bump-patch-for-minor-pre-major: true | ||
manifest-file: .release-please-manifest.json | ||
config-file: .release-please.json | ||
changelog-types: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think this will be good addition to help enforce conventional commits but is it directly related to monorepo work? May be better for a follow up PR so that we can discuss the conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this was copied from the js-ipfs workflow which uses release please to do gated monorepo releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, and release please looks for Conventional Commit messages to automate our releases. I personally prefer this style of conventional commits but I was just making a suggestion for a discussion before going ahead with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's not much to discuss - the commit style is the same as it was before, this is just config necessary to get release please to perform the gated releases as before.
Converts this repository to a monorepo - in the initial pass the only monorepo package is libp2p itself.
6540471
to
2a82858
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a minor comment regarding the retention of the migration template but that shouldn't prevent this from being merged.
test-firefox-webworker, | ||
test-electron-main, | ||
test-electron-renderer, | ||
test-interop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test-examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Examples are tested in a separate workflow file, I don't think you can depend on jobs defined in other files yet.
Merging because keeping this up to date is very painful. Multidim interop is failing - #1809 |
Converts this repository to a monorepo - in the initial pass the only monorepo package is libp2p itself.
Converts this repository to a monorepo - in the initial pass the only monorepo package is libp2p itself.
Other packages can be added in follow up PRs.
Refs #824