Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert to monorepo #1792

Merged
merged 4 commits into from
Jun 14, 2023
Merged

chore: convert to monorepo #1792

merged 4 commits into from
Jun 14, 2023

Conversation

achingbrain
Copy link
Member

Converts this repository to a monorepo - in the initial pass the only monorepo package is libp2p itself.

Other packages can be added in follow up PRs.

Refs #824

@achingbrain achingbrain marked this pull request as draft June 5, 2023 11:39
@achingbrain achingbrain force-pushed the chore/convert-to-monorepo branch from dbbbeb0 to ef76b7a Compare June 5, 2023 12:40
@achingbrain achingbrain mentioned this pull request Jun 5, 2023
3 tasks
@achingbrain achingbrain force-pushed the chore/convert-to-monorepo branch 3 times, most recently from a5988c5 to 6540471 Compare June 6, 2023 10:19
@achingbrain achingbrain marked this pull request as ready for review June 6, 2023 11:59
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work on this! Will hopefully improve both DX and release management 🥳 I left some comments.

.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
bump-patch-for-minor-pre-major: true
manifest-file: .release-please-manifest.json
config-file: .release-please.json
changelog-types: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think this will be good addition to help enforce conventional commits but is it directly related to monorepo work? May be better for a follow up PR so that we can discuss the conventions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was copied from the js-ipfs workflow which uses release please to do gated monorepo releases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, and release please looks for Conventional Commit messages to automate our releases. I personally prefer this style of conventional commits but I was just making a suggestion for a discussion before going ahead with it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not much to discuss - the commit style is the same as it was before, this is just config necessary to get release please to perform the gated releases as before.

ISSUE_TEMPLATE.md Outdated Show resolved Hide resolved
MIGRATION_TEMPLATE.md Outdated Show resolved Hide resolved
OKR.md Outdated Show resolved Hide resolved
.release-please-manifest.json Outdated Show resolved Hide resolved
Converts this repository to a monorepo - in the initial pass the only
monorepo package is libp2p itself.
@achingbrain achingbrain force-pushed the chore/convert-to-monorepo branch from 6540471 to 2a82858 Compare June 7, 2023 05:28
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a minor comment regarding the retention of the migration template but that shouldn't prevent this from being merged.

test-firefox-webworker,
test-electron-main,
test-electron-renderer,
test-interop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test-examples?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples are tested in a separate workflow file, I don't think you can depend on jobs defined in other files yet.

@achingbrain
Copy link
Member Author

Merging because keeping this up to date is very painful.

Multidim interop is failing - #1809

@achingbrain achingbrain merged commit f3e17cf into master Jun 14, 2023
@achingbrain achingbrain deleted the chore/convert-to-monorepo branch June 14, 2023 08:59
achingbrain added a commit that referenced this pull request Jun 14, 2023
Converts this repository to a monorepo - in the initial pass the only
monorepo package is libp2p itself.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants