Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add non-interface modules to monorepo #1828

Merged
merged 11 commits into from
Jun 16, 2023

Conversation

achingbrain
Copy link
Member

Adds all supported non-interface modules to the monorepo.

@achingbrain achingbrain merged commit 3dfc236 into master Jun 16, 2023
@achingbrain achingbrain deleted the chore/add-non-interface-modules branch June 16, 2023 12:49
@BigLep
Copy link
Contributor

BigLep commented Jun 19, 2023

@achingbrain @p-shahi : have we lost all the git history of these files (same goes with #1823 )? Given the age of the codebase, it seems unfortunate to lose the history of how the code evolved. With all the repo consolidation we did with Boxo, we maintained the commit history: https://github.com/ipfs/boxo/wiki/Copied-or-Migrated-Repos-FAQ#was-the-git-history-maintained-for-repos-that-were-copied-in .

@p-shahi
Copy link
Member

p-shahi commented Jun 19, 2023

Yeah it looks like this was missed, I believe history was maintained in the go-libp2p monorepo consolidation as well. If it's not too late to add it back and git allows for such a thing, I would be in favor of that.
I would also like to transfer issues from archived repos into this one. I manually unarchived https://github.com/libp2p/js-libp2p-webrtc earlier today and migrated issues, it looks like not all have been archived yet though

@achingbrain
Copy link
Member Author

I can add it back but it'll mean force pushing to master. I hadn't done it because I previously did for the repo consolidation of js-ipfs but I don't think anyone ever actually went spelunking deep in the repo history so it didn't seem worth the effort involved but from an OSS point of view it's probably a good idea to preserve contributor history if nothing else.

The simplest way to do this is probably to push straight to master rather than go via a PR.

achingbrain added a commit that referenced this pull request Jun 19, 2023
Adds all supported non-interface modules to the monorepo.
@achingbrain
Copy link
Member Author

Your branch and 'origin/master' have diverged,
and have 3828 and 1 different commits each, respectively.
  (use "git pull" to merge the remote branch into yours)

😱

@BigLep
Copy link
Contributor

BigLep commented Jun 19, 2023

I'm going to move the conversation into the monorepo issue which is still open: #824

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants