-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add non-interface modules to monorepo #1828
Conversation
Adds all supported non-interface modules to the monorepo.
@achingbrain @p-shahi : have we lost all the git history of these files (same goes with #1823 )? Given the age of the codebase, it seems unfortunate to lose the history of how the code evolved. With all the repo consolidation we did with Boxo, we maintained the commit history: https://github.com/ipfs/boxo/wiki/Copied-or-Migrated-Repos-FAQ#was-the-git-history-maintained-for-repos-that-were-copied-in . |
Yeah it looks like this was missed, I believe history was maintained in the go-libp2p monorepo consolidation as well. If it's not too late to add it back and git allows for such a thing, I would be in favor of that. |
I can add it back but it'll mean force pushing to master. I hadn't done it because I previously did for the repo consolidation of The simplest way to do this is probably to push straight to master rather than go via a PR. |
Adds all supported non-interface modules to the monorepo.
😱 |
I'm going to move the conversation into the monorepo issue which is still open: #824 |
Adds all supported non-interface modules to the monorepo.