Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: consolidate interface modules #1833

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Jun 16, 2023

Consolidates all interface modules to @libp2p/interface for external (eg. user-consumable) interfaces and @libp2p/interface-internal for interfaces implemented or consumed by internal libp2p modules (managers, etc).

Merges all interface compliance tests and mocks into @libp2p/interface-compliance-tests

Closes #824

Consolidates all interface modules to `@libp2p/interface` for external (eg. user-consumable) interfaces and
`@libp2p/interface-internal` for interfaces implemented or consumed by internal libp2p modules (managers, etc).

Merges all interface compliance tests and mocks into `@libp2p/interface-compliance-tests`

Closes #824
@achingbrain achingbrain force-pushed the fix/consolidate-interface-modules branch from 87004bc to cfdb90c Compare June 19, 2023 11:39
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge PR so there may have been something I missed. Perhaps there is a way to parse the diff for changes not related to imports/ paths but given that this is blocking other PRs that may not be viable at the moment.

@maschad maschad merged commit 4255b1e into master Jun 19, 2023
@maschad maschad deleted the fix/consolidate-interface-modules branch June 19, 2023 19:35
@github-actions github-actions bot mentioned this pull request Jun 20, 2023
This was referenced Jan 18, 2024
@achingbrain achingbrain mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider libp2p mono repo
2 participants