Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare libp2p v0.52.3 #4387

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Conversation

mxinden
Copy link
Member

@mxinden mxinden commented Aug 24, 2023

Description

Notes & open questions

@thomaseizinger @jxs any objections?

//CC @MOZGIII

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@mxinden mxinden requested review from jxs and thomaseizinger August 24, 2023 08:23
@jxs
Copy link
Member

jxs commented Aug 24, 2023

No no Max, thanks for the fast diligence! 🚀

@mxinden
Copy link
Member Author

mxinden commented Aug 24, 2023

Mergify doesn't have permission to update
For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/cache-factory.yml without workflows permission
err-code: 965D3

Surprising. Did we change mergify's permissions in https://github.com/libp2p/github-mgmt? @thomaseizinger this would explain the failures we have seen with pull requests from external contributors.

@thomaseizinger
Copy link
Contributor

Mergify doesn't have permission to update
For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/cache-factory.yml without workflows permission
err-code: 965D3

Surprising. Did we change mergify's permissions in libp2p/github-mgmt? @thomaseizinger this would explain the failures we have seen with pull requests from external contributors.

I am not aware of any changes. I think what is happening here is that the required update of the branch will pull in the latest commit on master: 4284cae

That one changes a workflow file which might cause this problem?

@mergify mergify bot merged commit e8759c8 into libp2p:master Aug 24, 2023
@mxinden
Copy link
Member Author

mxinden commented Aug 24, 2023

Tagged and published the following crates:

  • libp2p-noise-v0.43.1
  • libp2p-quic-v0.9.2
  • libp2p-tls-v0.2.1
  • libp2p-v0.52.3
  • libp2p-websocket-v0.42.1

Note that libp2p-server is missing. I will follow-up with a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants