Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SwarmBuilder): add with_connection_timeout method #5575

Conversation

stormshield-frb
Copy link
Contributor

Description

Small PR to be able to change the connection_timeout value given to the TransportTimeout when building the Swarm with a SwarmBuilder.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@stormshield-frb stormshield-frb force-pushed the feat/add-connection-timeout-to-swarm-builder branch from df78e2c to f78ea9d Compare August 28, 2024 15:28
@stormshield-frb stormshield-frb force-pushed the feat/add-connection-timeout-to-swarm-builder branch from f78ea9d to 1300365 Compare August 28, 2024 15:30
libp2p/CHANGELOG.md Outdated Show resolved Hide resolved
@jxs jxs force-pushed the feat/add-connection-timeout-to-swarm-builder branch from f8122ed to 2caa95d Compare December 13, 2024 19:41
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks François!

@jxs jxs added the send-it label Dec 14, 2024
@mergify mergify bot merged commit 89af870 into libp2p:master Dec 14, 2024
108 of 139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants