-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update Cargo.lock #5755
Conversation
a84d6d3
to
2f16d84
Compare
Dependencies are managed by bots automatically, I don't think it is a good idea to just run |
@drHuangMHT As I understand, dependabot manages only direct dependencies, while
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @hanabi1224!
@drHuangMHT As I understand, dependabot manages only direct dependencies, while
cargo update
bumps all indirect dependencies as well. Also, sincelibp2p
works as libraries, havingCargo.lock
in source control could give some false sense of security, it's important to regularly update all indirect dependencies. e.g.libp2p-webrtc
smote test scenario does not work without lockingwebrtc-ice = "=0.10.0"
, or excludeCargo.lock
from source control.However, this determinism can give a false sense of security because Cargo.lock does not affect the consumers of your package, only Cargo.toml does that.
yeah this PR is helpful due to also the freeze in the webrc-ice
freeze, can you just address the comment?
Thanks!
- run `cargo update` - lock `webrtc-ice = "=0.10.0"` to not break webrtc smoke tests - fix `cargo clippy` warnings - update `deny.toml` accordingly Pull-Request: libp2p#5755.
Description
cargo update
webrtc-ice = "=0.10.0"
to not break webrtc smoke testscargo clippy
warningsdeny.toml
accordinglyNotes & open questions
Change checklist