Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(quic): update quinn to 0.11.6 #5757

Merged
merged 3 commits into from
Dec 25, 2024
Merged

Conversation

kalabukdima
Copy link
Contributor

@kalabukdima kalabukdima commented Dec 23, 2024

Description

Among other changes, it includes a fix for this issue which often reproduces with libp2p: quinn-rs/quinn#1889

Notes & open questions

The list of changes: quinn-rs/quinn@quinn-0.11.2...quinn-0.11.6

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I wonder if we should bump it to 0.11.6 since there seems to be additional changes and possible fixes up that point as well. Thoughts?

@kalabukdima
Copy link
Contributor Author

Thanks for the PR. I wonder if we should bump it to 0.11.6 since there seems to be additional changes and possible fixes up that point as well. Thoughts?

Sure, I would gladly update to the latest version! I was just not sure what is libp2p's policy for dependency updates. I didn't review the changes, but hopefully "fix" version updates won't break anything.

@kalabukdima kalabukdima changed the title deps(quic): update quinn to 0.11.3 deps(quic): update quinn to 0.11.6 Dec 24, 2024
Copy link
Contributor

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Version bump isn't needed because we didn't release libp2p-quic-0.11.2 yet.

transports/quic/Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
transports/quic/CHANGELOG.md Outdated Show resolved Hide resolved
dariusc93 and others added 2 commits December 24, 2024 06:26
Co-authored-by: Elena Frank <elena.frank@proton.me>
Copy link
Contributor

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mergify mergify bot merged commit 69cf073 into libp2p:master Dec 25, 2024
71 checks passed
@kalabukdima kalabukdima deleted the update-quinn branch December 26, 2024 07:31
jxs pushed a commit to jxs/rust-libp2p that referenced this pull request Jan 6, 2025
Among other changes, it includes a fix for this issue which often reproduces with libp2p: quinn-rs/quinn#1889

Pull-Request: libp2p#5757.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants