-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: direct messages #120
Conversation
chore: js-peer bump deps including libp2p to 1.x
…, protocol dropdown on peer, timestamps on messages
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
}), | ||
dht: kadDHT({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for enabling the DHT in the browser again?
I added delegated routing to avoid running a DHT client in the browser, but if there's a good reason, we can enable.
Also see #113 for more background on why this app relies on the IPFS DHT.
console.log('undiscovered peer', evt.detail.from.toString()) | ||
|
||
if (libp2p.getConnections().length < AutoDialerMaxConnections) { | ||
await libp2p.dial(evt.detail.from) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried this out and can you tell whether this works for two browsers behind NAT?
Thanks for submitting this PR. I skimmed through the PR and looked at the preview and it looks like you've cleaned up and refactored a lot which is great. Before giving this a more thorough review, some initial feedback:
|
Any thoughts @dozyio. Really appreciate this PR! |
I agree with this however what if you instead just implemented something that has some level of adoption such as the LIME Protocol. I'm all for this PR landing. Let's make it happen. |
See #175 |
download/blockies
withreact-18-blockies