Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-peer: do not add externally observed maddrs #132

Closed
wants to merge 3 commits into from
Closed

rust-peer: do not add externally observed maddrs #132

wants to merge 3 commits into from

Conversation

2color
Copy link
Collaborator

@2color 2color commented Apr 29, 2024

Might fix #131

@2color 2color requested a review from a team April 29, 2024 14:44
@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universal-connectivity ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 11:43am

@2color 2color mentioned this pull request Apr 29, 2024
Closed
AgeManning
AgeManning reviewed Apr 30, 2024
View reviewed changes
Copy link

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this is a NAT'ing issue. I commented on the original issue.

It is probably also not great form to just add the observed address to known external addresses. I'm not all that familiar with this code base, but removing the line you have commented out, I don't imagine will do much harm.

Although you may want to keep track and if at least a handful of nodes report the same address, then it would be safe to add as a known external address.

@MarcoPolo
Copy link

Although you may want to keep track and if at least a handful of nodes report the same address, then it would be safe to add as a known external address.

👍 This is what go-libp2p does by default.

@2color 2color closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgeManning AgeManning AgeManning left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rust peer is announcing wrong multiaddrs
3 participants
@2color @MarcoPolo @AgeManning