Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network: Do not configure protocols on DSA switch port network devices by default. #1161

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pony1k
Copy link
Contributor

@pony1k pony1k commented Jan 5, 2025

work around issue #1121

This adds an optional parameter 'port' to util.is_dsa(), to allow checking if a specific network device is a DSA switch port and prevents such network devices to be configured with protocols other than 'lime-proto-lan', unless there is a 'config net' section for that network device.

pony1k added 2 commits January 5, 2025 09:52
Allow to check if a specific port is a DSA user port. Without arguments
the function behaviour does not change.
...by default, to avoid configuring switch ports simultaneously for
stand-alone mode and bridge mode. 'config net' sections can still be
used to configure routing protocols on switch port network devices.
@pony1k
Copy link
Contributor Author

pony1k commented Jan 5, 2025

@ilario Can this workaround go into the 2024.1release?

@ilario
Copy link
Member

ilario commented Jan 5, 2025

Thanks Pony!!!
I will test it.
No idea if @a-gave already started compiling stuff...?

@ilario
Copy link
Member

ilario commented Jan 5, 2025

@G10h4ck @digitigrafo can you also have a look/test? Do you think it is ok to delay the 2024.1 release for having the time to test this?

@a-gave
Copy link
Contributor

a-gave commented Jan 5, 2025

Thanks Pony!!! I will test it. No idea if @a-gave already started compiling stuff...?

No, but I am running the preliminary steps/checks.
It looks good and I would have no problem including it if it works as expected.
I was waiting for the next 2024.1 or 2024.1-rc2 tag to do the final steps and produce the firmwares.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants