-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint code #402
Lint code #402
Conversation
Hi @rodrigoargumedo, Ahhh they keep adding new rules and breaking our CI. Sure, happy to change this, though the lint is still failing (not sure why). |
@jcupitt Thanks for the quick response. Do we want to enforce this rule or exclude it from being linted? |
The rule sounds reasonable, so let's make this change. Thanks for volunteering! |
It seems that the failing CI job was run on commit 7a2b9ba. I tried restarting it, but to no avail. |
It's failing due to branch is not equal to |
Once merged, it will pass. |
Ah, I think it's due to this: ruby-vips/.github/workflows/test.yml Lines 8 to 10 in 7a2b9ba
|
Ah! Of course. I assumed it was linting the branch. Thanks again. |
PR #403 removes this confusing |
Hi,
I saw that the linting Actions job was failing and decided to correct it to pass.
From
standardrb
:Please let me know if you have any questions for me.