Return to v5.8, since this is a prerequisite to HTML::HeadParser and LWP::UserAgent #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a dependency for HTML::Parser, which is a dependency for LWP::UserAgent. Both of those have a minimum version of v5.8.
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
briandfoy
had a problem deploying
to
automated_testing
GitHub Actions
Failure
We can't install from CPAN so we need to get there first with a version that will work.
briandfoy
added a commit
to briandfoy/text-multimarkdown
that referenced
this pull request
Sep 20, 2024
briandfoy
added a commit
to briandfoy/github_workflows
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't see any v5.10 features here, and the tests pass under v5.8. This module is a pre-requisite to other modules that have minimum versions of v5.8, which means this module moving to v5.10 inadvertently breaks modules that should work with v5.8.
Also, along the way GitHub has screwed up workflows such that we can't use the old perl images: Perl/docker-per#161 . I threw in my basic Ubuntu workflow file from briandfoy/github_workflows, but you don't have to use that. It does have one change to get around installing this module from CPAN on v5.8.
The Changes files noted a lack of infrastructure to test on v5.8, but GitHub workflows and CPAN Testers will handle that. And, there are v5.8 docker images too.