Adding the optional ability to set the size of each file read when DYNAM... #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NAMIC_FILE_UPLOAD is being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...IC_FILE_UPLOAD is being used.
When I do large file uploads with $DYNAMIC_FILE_UPLOAD it's hard coded to read the file in 2048 byte chunks. I find that this makes for some very slow transfers. As a test I went in and modified to to send 64k chunks and the transfer was much faster.
I'm proposing a possible solution to allow the user to set the amount of bytes they want to read at a time from the file. I'm open to discussion or implementing other ways but this seems like it fits with the interface.