New ref content #23
Open
New ref content #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it is a ref, dereference it before doing utf8::downgrade on it.
This addresses issue libwww-perl#13 in GitHub
is a ref, addressing Github issue libwww-perl#13
|
Any change in functionality should be covered by a test case that fails before the associated .pm change is applied, so we can be sure not to regress the change. It also helps demonstrate the intent behind the change for future readers. |
prove t/message.t t/message.t .. 1/131 # Test 131 got: <UNDEF> (t/message.t at line 500) t/message.t .. Failed 1/131 subtests Test Summary Report ------------------- t/message.t (Wstat: 0 Tests: 131 Failed: 1) Failed test: 131 Files=1, Tests=131, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.09 cusr 0.00 csys = 0.11 CPU) Result: FAIL prove -b t/message.t t/message.t .. ok All tests successful. Files=1, Tests=131, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.09 cusr 0.00 csys = 0.13 CPU) Result: PASS
|
Ah. I've added a test that fails on 6.06 and passes with this fix. Is this sufficient to move forward? Thanks for your patience... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #13 in Github identified a problem when new() is passed $content as a ref. In particular, it seems that utf8_downgrade doesn't get properly done. My fix was to have new capture the new object and if the content is a ref, then call content_ref to set it using the existing logic.