Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "URI-5.22" #134

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Revert "URI-5.22" #134

merged 1 commit into from
Jan 25, 2024

Conversation

oalders
Copy link
Member

@oalders oalders commented Jan 25, 2024

This reverts commit fc3628d.

The following warnings were introduced:

Use of uninitialized value in string eq at /root/.cpan/build/URI-5.22-0/blib/lib/URI/_query.pm line 38.
Use of uninitialized value in string eq at /root/.cpan/build/URI-5.22-0/blib/lib/URI/_query.pm line 53.
Use of uninitialized value in string eq at /root/.cpan/build/URI-5.22-0/blib/lib/URI/_query.pm line 118.
Use of uninitialized value in string eq at /root/.cpan/build/URI-5.22-0/blib/lib/URI/_query.pm line 172.

@jackdeguest FYI ^^^

This reverts commit fc3628d.
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08b00a0) 87.38% compared to head (ec70d7f) 87.38%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files          50       50           
  Lines        1783     1783           
  Branches      462      462           
=======================================
  Hits         1558     1558           
  Misses         77       77           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oalders oalders merged commit 8f8b549 into master Jan 25, 2024
44 checks passed
@oalders oalders deleted the oalders/revert-reftype branch January 25, 2024 21:01
@jackdeguest
Copy link

This reverts commit fc3628d.

The following warnings were introduced:

Use of uninitialized value in string eq at /root/.cpan/build/URI-5.22-0/blib/lib/URI/_query.pm line 38.
Use of uninitialized value in string eq at /root/.cpan/build/URI-5.22-0/blib/lib/URI/_query.pm line 53.
Use of uninitialized value in string eq at /root/.cpan/build/URI-5.22-0/blib/lib/URI/_query.pm line 118.
Use of uninitialized value in string eq at /root/.cpan/build/URI-5.22-0/blib/lib/URI/_query.pm line 172.

@jackdeguest FYI ^^^

Maybe we could add instead if (defined($r) && Scalar::Util::reftype($r) eq "ARRAY") ?
That would resolve this issue, don't you think ?

@oalders
Copy link
Member Author

oalders commented Jan 25, 2024

Yes. That would work. We should also check that the code paths which generated the warnings are covered by tests. Possibly we are not failing tests when warnings occur. Not sure. I'm on my phone right now. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants