Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "use Scalar::Util::reftype instead of ref to check for ARRAY" #136

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

oalders
Copy link
Member

@oalders oalders commented Jan 26, 2024

This reverts commit 1d5be19.

Closes #135

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (8f8b549) 87.38% compared to head (d92a6fa) 87.37%.
Report is 2 commits behind head on master.

Files Patch % Lines
lib/URI/_query.pm 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   87.38%   87.37%   -0.01%     
==========================================
  Files          50       50              
  Lines        1783     1782       -1     
  Branches      462      462              
==========================================
- Hits         1558     1557       -1     
  Misses         77       77              
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oalders oalders merged commit 0c6923f into master Jan 26, 2024
42 of 44 checks passed
@oalders oalders deleted the oalders/really-revert branch January 26, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URI 5.22, 5.23 causes HTML::Form tests to fail
1 participant