Add scp, ftps, ftpes, irc, ircs schemes #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this duplicates modules already on the cpan, appropriate permissions would need to be granted by those that currently hold them. |
|
Perhaps that can be split off into a separate issue. I can adjust the branch and create another PR. |
SineSwiper
changed the title
|
Ping! |
SineSwiper
changed the title
SineSwiper
force-pushed
the
topic/more_schemes
branch
from
275946a
to
041f018
Compare
karenetheridge
force-pushed
the
master
branch
from
5dcfddf
to
3a2965a
Compare
|
It looks like we're now shipping |
SineSwiper
force-pushed
the
topic/more_schemes
branch
from
041f018
to
577e546
Compare
SineSwiper
force-pushed
the
topic/more_schemes
branch
from
577e546
to
0f0681d
Compare
|
@oalders, @karenetheridge Apologies for the (very late) delay, but I noticed there was still an interest in getting this merged. So, I rebased it and cleaned it up to match the newer URI fixes (Test::More, DZIL, etc.). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added several schemes that were simple to implement, as they were aliases or mostly aliases to existing types. I also added the irc scheme, based on existing IRC URI drafts, and its secure cousin, ircs.
URI::sftp is already out there in the wild, but it would be nice to bring this thing into the core URI distro.