-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use FIDE table for elo calculation #581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenguyenthanh
requested changes
Sep 27, 2024
I think both Instead of val conversionTableFIDE: Map[Range.Inclusive, BigDecimal] = Map(
(0 to 3) -> 0.50,
(4 to 10) -> 0.51,
(11 to 17) -> 0.52,
[...]
val expectedScore = conversionTableFIDE.collectFirst {
case (range, pd) if range.contains(absRatingDiff) => pd
I would prefer to see val conversionTableFIDE: List[Int, BigDecimal] = List(
3 -> 0.50,
10 -> 0.51,
17 -> 0.52,
[...]
val expectedScore = conversionTableFIDE.collectFirst {
case (upperBound, pd) if upperBound >= absRatingDiff => pd |
ornicar
reviewed
Sep 28, 2024
I was thinking of a Map with multiple keys point to the same value: val conversionTableFIDE: Map[Int, BigDecimal] = mapOf(
0 -> 0.5,
1 -> 0.5,
2 -> 0.5,
3 -> 0.5,
...
15 -> 0.52,
16 -> 0.52,
17 -> 0.52,
....
391 -> 0.91
) and we can do (pseudo code) def getExpectedScore(ratingDiff: Int): BigDecimal =
conversionTableFIDE.getOrElse(ratingDiff, 0.92) |
lenguyenthanh
approved these changes
Sep 28, 2024
gentle ping @ornicar for reviewing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #579