Upgrade scalalib to 11.3.0 #585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix timestamper by renaming method.
|
Let's keep this in draft until we're sure we can use 11.3.0 scalalib. |
| @@ -3,12 +3,12 @@ package chess | |||
| opaque type Timestamp = Long | |||
| object Timestamp extends OpaqueLong[Timestamp]: | |||
| extension (t: Timestamp) | |||
| def -(o: Timestamp): Centis = Centis.ofMillis(t - o.value) | |||
There was a problem hiding this comment.
should we remove custom operators from scalalib instead? It'll leads to less surprised. We can re-add it if we needed in the future.
There was a problem hiding this comment.
Hmm. I am not sure what is best. It seems odd to me that OpaqueInt is special cased with methods. But you could go the other way, and rename it to RichOpaqueInt leaving an empty OpaqueInt in its place.
There was a problem hiding this comment.
I think the reason here is Int and Long are not symmetrical. We use Int arithmetic much more than Long. If we use Long arithmetic that much, we already add them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix timestamper by renaming method.