Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile menu design updated, error-button overlap fixed #106

Conversation

manneredboor
Copy link
Contributor

@manneredboor manneredboor commented Jun 22, 2023

Description

Mobile menu design updated, error-button overlap fixed.

Demo

Before / After
image

Checklist:

  • Checked the changes locally.

@manneredboor manneredboor requested review from a team as code owners June 22, 2023 13:16
@linear
Copy link

linear bot commented Jun 22, 2023

ETHUI-220 Mobile mode: error pop-over overlapping connect button

В мобильной версии кнопка коннект и ошибка пересекаются и накладываются друг на друга. Это не критично, т.к. при нажатии на ошибку, она пропадает. Может стоит кнопку перенести или ошибку иначе показывать?

https://discord.com/channels/761182643269795850/1069652060636725378/1072168606667907155

image.png

https://discord.com/channels/761182643269795850/1069652060636725378/1072462401347272804

thank you! I can propose to slightly change the menu to this and move the connect wallet button up so it doesn't interact with the error https://www.figma.com/file/rbrO2k3ZzFKOsVSb12ob4W/Vote-UI-Interface?node-id=0%3A1

image.png

@preview-stands
Copy link

preview-stands bot commented Jun 22, 2023

Preview stand status

Stand was demolished

@vtrush88 vtrush88 merged commit d0b229b into develop Jul 6, 2023
4 checks passed
@manneredboor manneredboor deleted the feature/ethui-220-mobile-mode-error-pop-over-overlapping-connect-button branch September 6, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants