Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for additional contract proxy method in evm decoding pipeline #113

Conversation

manneredboor
Copy link
Contributor

@manneredboor manneredboor commented Jul 4, 2023

Description

Support for additional contract proxy method in evm decoding pipeline

Testing notes

  1. Disable checkbox on Settings —> Use built-in ABIs and click Save
  2. Check votes
    2.1 Vote #517 (Goerli); Step 2.1: call on StakingRouter should be parsed
    2.2 Vote test deploy preview #159 (Mainnet); Step 2.1: call on StakingRouter should be parsed

Before/After

image

Checklist:

  • Checked the changes locally.

@manneredboor manneredboor requested review from a team as code owners July 4, 2023 13:55
@linear
Copy link

linear bot commented Jul 4, 2023

ETHUI-511 Check that evm-script-decoder supports all types of proxy-contract in use

Use-cases for decoding abi's with etherscan, not with embed abi's

https://github.com/lidofinance/evm-script-decoder

Votes to check:

#159; Step 2.1: OssifiableProxy for StakingRouter

@preview-stands
Copy link

preview-stands bot commented Jul 4, 2023

Preview stand status

Stand was demolished

@vtrush88 vtrush88 merged commit a6ef2ec into develop Jul 6, 2023
4 checks passed
@manneredboor manneredboor deleted the feature/ethui-511-check-that-evm-script-decoder-supports-all-types-of-proxy branch July 6, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants