Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: async condition legacy sdk chainId #536

Merged
merged 6 commits into from
Nov 11, 2024
Merged

fix: async condition legacy sdk chainId #536

merged 6 commits into from
Nov 11, 2024

Conversation

Jeday
Copy link
Contributor

@Jeday Jeday commented Nov 6, 2024 •
edited
Loading

Description

  • prevent async race condition for legacy sdk
  • only change chainType when user changes to supported chain
  • show add nft helper link for all injected wallets
  • force refetch of allowance to bypass laggy user rpcs
  • up patch version for wagmi/viem

Demo

Code review notes

Testing notes

Checklist:

  • Checked the changes locally.
  • Created / updated analytics events.
  • Created / updated the technical documentation (README.md / docs / etc.).
  • Affects / requires changes in other services (Matomo / Sentry / CloudFlare / etc.).

@Jeday Jeday requested review from a team as code owners November 6, 2024 08:04
@preview-stands
Copy link

preview-stands bot commented Nov 6, 2024 •
edited
Loading

Preview stand status

Stand was demolished

solidovic
solidovic previously approved these changes Nov 7, 2024
View reviewed changes
DiRaiks
DiRaiks previously approved these changes Nov 7, 2024
View reviewed changes
itaven
itaven previously approved these changes Nov 7, 2024
View reviewed changes
solidovic
solidovic previously approved these changes Nov 7, 2024
View reviewed changes
@Jeday Jeday dismissed stale reviews from solidovic, itaven, and DiRaiks via c175c4c November 8, 2024 12:04
@Jeday Jeday force-pushed the feature/si-1641-refactoring-single-source-of-truth-for-chainid-and-rpc branch from c175c4c to bc21e86 Compare November 8, 2024 13:51
@Jeday Jeday requested a review from DiRaiks November 8, 2024 14:08
@itaven itaven merged commit 4f02cb2 into develop Nov 11, 2024
6 checks passed
@itaven itaven deleted the feature/si-1641-refactoring-single-source-of-truth-for-chainid-and-rpc branch November 11, 2024 09:04
@itaven itaven mentioned this pull request Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiRaiks DiRaiks DiRaiks approved these changes

@solidovic solidovic solidovic approved these changes

@itaven itaven itaven left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jeday @solidovic @itaven @DiRaiks