-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat]: nested rendering contexts #177
Conversation
✅ Deploy Preview for g-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
da60356
to
8e1c800
Compare
Remove fallback mechanism for setting up and looking up the DOM API in `_DOM` function. * Remove the fallback mechanism involving `oldAPI` and ensure `api` is correctly set without fallback logic. * Update the `_DOM` function to use the `api` variable directly. * Reformat the `updatingCell` formula for better readability. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/lifeart/glimmer-next/tree/nested-rendering-context?shareId=XXXX-XXXX-XXXX-XXXX).
Code Coverage ReportCoverage after merging nested-rendering-context into master
Coverage Report
|
duration phase estimated improvement -166ms [-280ms to -63ms] OR -1.22% [-2.05% to -0.46%] [07:37:04] Generating Benchmark Reports [started]
JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html |
bb2d7db
to
69fa24f
Compare
replaces: #177
Features:
Todo:
Get rid ofcontext
on args?Get rid ofowner
in destructors