Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix corner cases & public api update #192

Merged
merged 2 commits into from
Jan 17, 2025
Merged

fix corner cases & public api update #192

merged 2 commits into from
Jan 17, 2025

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Jan 17, 2025

fixed cases where we have dynamic function in root of component and it's breaking hot-reloading

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit f40352a
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/678a2a84290053000873fd5b
😎 Deploy Preview https://deploy-preview-192--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

fix corner cases
Copy link

github-actions bot commented Jan 17, 2025

Code Coverage Report

Coverage after merging fix-corner-cases into master

78.04%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts806, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.4483.3318, 27
tests
   utils.ts98.5494.44119, 120, 121
utils
   component.ts98.0939, 52, 55, 95, ...
   context.ts46, 54, 75, 82, ...
   dom-api.ts96.6726, 40, 41, 42, ...
   dom.ts98.0395.56958, 970, 984, 985, ...
   math-api.ts96.9721, 22
   reactive.ts93.0697.2249, 63, 68, 69, ...
   runtime.ts93.5518, 21, 22, 23, ...
   shared.ts62, 68, 70, 94, ...
   svg-api.ts82.2227, 28, 29, 30, ...
   vm.ts24, 4
utils/benchmark
   benchmark.ts67.4424, 25, 26, 27, ...
   compat.ts96.2328, 29, 30, 38, ...
utils/control-flow
   if.ts73.5476.9295, 96, 97, 98, ...
   list.ts94.9490.9191, 92, 93, 94, ...
utils/glimmer
   destroyable.ts12, 26, 36, 50, ...
utils/helpers
   and.ts77.784, 5, 6
   eq.ts3, 4
   hash.ts81.8266.6714, 15, 16, 17, ...
   if.ts71.433, 4, 5
   or.ts4
utils/inspector
   ember-inspector.ts12.45096, 97, 98, 99, ...
   index.ts33.33096, 97, 98, 99, ...
utils/ssr
   rehydration-dom-api.ts50.9186, 87, 98, 99, ...
   rehydration.ts153, 39, 42, 79, ...

@lifeart lifeart changed the title fix corner cases fix corner cases & public api update Jan 17, 2025
@lifeart lifeart marked this pull request as ready for review January 17, 2025 10:09
Copy link

github-actions bot commented Jan 17, 2025

duration phase estimated improvement -114ms [-166ms to -62ms] OR -0.92% [-1.33% to -0.49%]
renderEnd phase no difference [-1ms to 2ms]
render1000Items1End phase estimated improvement -11ms [-17ms to -5ms] OR -1.35% [-2.08% to -0.64%]
clearItems1End phase no difference [-2ms to 1ms]
render1000Items2End phase estimated improvement -13ms [-16ms to 0ms] OR -1.89% [-2.41% to -0.06%]
clearItems2End phase no difference [0ms to 0ms]
render5000Items1End phase estimated improvement -22ms [-36ms to -8ms] OR -0.67% [-1.09% to -0.26%]
clearManyItems1End phase no difference [-4ms to 0ms]
render5000Items2End phase estimated improvement -25ms [-38ms to -12ms] OR -0.83% [-1.25% to -0.4%]
clearManyItems2End phase no difference [-3ms to 0ms]
render1000Items3End phase no difference [-9ms to 1ms]
append1000Items1End phase estimated improvement -13ms [-26ms to -3ms] OR -1.93% [-3.86% to -0.44%]
append1000Items2End phase no difference [-20ms to 2ms]
updateEvery10thItem1End phase no difference [-8ms to 4ms]
updateEvery10thItem2End phase no difference [-1ms to 1ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [0ms to 0ms]
removeSecondRow1End phase no difference [0ms to 1ms]
swapRows1End phase no difference [0ms to 1ms]
swapRows2End phase no difference [0ms to 1ms]
clearItems4End phase no difference [-2ms to 1ms]
paint phase no difference [0ms to 0ms]

[11:44:36] Generating Benchmark Reports [started]
[11:44:44] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

@lifeart lifeart merged commit aaa6cda into master Jan 17, 2025
8 checks passed
@lifeart lifeart deleted the fix-corner-cases branch January 17, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant