Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get rid of context property #193

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Jan 17, 2025

image

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit 5a41cbb
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/678aa5d2f9e6a00008d1e2f9
😎 Deploy Preview https://deploy-preview-193--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 17, 2025

Code Coverage Report

Coverage after merging get-rid-of-context-property into master

78.01%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts806, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.4483.3318, 27
tests
   utils.ts98.4794.44113, 114, 115
utils
   component.ts98.0352, 55, 89, 94, ...
   context.ts46, 54, 72, 79, ...
   dom-api.ts96.6726, 40, 41, 42, ...
   dom.ts98.0595.74972, 984, 998, 999, ...
   math-api.ts96.9721, 22
   reactive.ts93.0697.2249, 63, 68, 69, ...
   runtime.ts93.5518, 21, 22, 23, ...
   shared.ts61, 67, 69, 93, ...
   svg-api.ts82.2227, 28, 29, 30, ...
   vm.ts24, 4
utils/benchmark
   benchmark.ts67.4424, 25, 26, 27, ...
   compat.ts96.2328, 29, 30, 38, ...
utils/control-flow
   if.ts73.1276.9292, 93, 94, 95, ...
   list.ts94.9090.9189, 9, 90, 91, ...
utils/glimmer
   destroyable.ts12, 26, 36, 50, ...
utils/helpers
   and.ts77.784, 5, 6
   eq.ts3, 4
   hash.ts81.8266.6714, 15, 16, 17, ...
   if.ts71.433, 4, 5
   or.ts4
utils/inspector
   ember-inspector.ts12.45096, 97, 98, 99, ...
   index.ts33.33096, 97, 98, 99, ...
utils/ssr
   rehydration-dom-api.ts50.9186, 87, 98, 99, ...
   rehydration.ts153, 39, 42, 79, ...

Copy link

github-actions bot commented Jan 17, 2025

duration phase no difference [-39ms to 112ms]
renderEnd phase no difference [-1ms to 3ms]
render1000Items1End phase no difference [-9ms to 4ms]
clearItems1End phase no difference [-3ms to 1ms]
render1000Items2End phase no difference [-16ms to 0ms]
clearItems2End phase no difference [0ms to 0ms]
render5000Items1End phase no difference [-27ms to 6ms]
clearManyItems1End phase no difference [-4ms to 1ms]
render5000Items2End phase no difference [-11ms to 21ms]
clearManyItems2End phase no difference [-2ms to 1ms]
render1000Items3End phase no difference [-12ms to 2ms]
append1000Items1End phase no difference [-7ms to 23ms]
append1000Items2End phase no difference [-6ms to 21ms]
updateEvery10thItem1End phase no difference [-7ms to 6ms]
updateEvery10thItem2End phase no difference [0ms to 16ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [-1ms to 1ms]
removeSecondRow1End phase no difference [-1ms to 1ms]
swapRows1End phase no difference [0ms to 1ms]
swapRows2End phase no difference [0ms to 1ms]
clearItems4End phase estimated regression +2ms [0ms to 4ms] OR +1.12% [0.11% to 2.09%]
paint phase no difference [0ms to 0ms]

[20:27:29] Generating Benchmark Reports [started]
[20:27:38] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

@lifeart lifeart marked this pull request as ready for review January 17, 2025 19:41
@lifeart lifeart merged commit 468fb45 into master Jan 17, 2025
8 checks passed
@lifeart lifeart deleted the get-rid-of-context-property branch January 17, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant