Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamline dom render #194

Closed
wants to merge 2 commits into from
Closed

streamline dom render #194

wants to merge 2 commits into from

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Jan 17, 2025

No description provided.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit 4725130
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/678b6281e3013d00087f4db8
😎 Deploy Preview https://deploy-preview-194--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Jan 17, 2025

Code Coverage Report

Coverage after merging streamline-dom-render into master

78.06%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts806, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.4483.3318, 27
tests
   utils.ts98.4794.44113, 114, 115
utils
   component.ts98.1055, 60, 63, 97, ...
   context.ts46, 54, 72, 79, ...
   dom-api.ts96.6726, 40, 41, 42, ...
   dom.ts98.0695.74972, 973, 976, 988, ...
   math-api.ts96.9721, 22
   reactive.ts93.0697.2249, 63, 68, 69, ...
   runtime.ts93.5518, 21, 22, 23, ...
   shared.ts61, 67, 69, 93, ...
   svg-api.ts82.2227, 28, 29, 30, ...
   vm.ts24, 4
utils/benchmark
   benchmark.ts67.4424, 25, 26, 27, ...
   compat.ts96.2328, 29, 30, 38, ...
utils/control-flow
   if.ts73.1276.9292, 93, 94, 95, ...
   list.ts94.9090.9189, 9, 90, 91, ...
utils/glimmer
   destroyable.ts12, 26, 36, 50, ...
utils/helpers
   and.ts77.784, 5, 6
   eq.ts3, 4
   hash.ts81.8266.6714, 15, 16, 17, ...
   if.ts71.433, 4, 5
   or.ts4
utils/inspector
   ember-inspector.ts12.45096, 97, 98, 99, ...
   index.ts33.33096, 97, 98, 99, ...
utils/ssr
   rehydration-dom-api.ts50.9186, 87, 98, 99, ...
   rehydration.ts153, 39, 42, 79, ...

Copy link

github-actions bot commented Jan 17, 2025

duration phase no difference [-83ms to 3ms]
renderEnd phase no difference [-2ms to 2ms]
render1000Items1End phase estimated regression +6ms [3ms to 9ms] OR +0.81% [0.4% to 1.23%]
clearItems1End phase estimated regression +2ms [0ms to 3ms] OR +2.97% [0.43% to 5.29%]
render1000Items2End phase estimated regression +8ms [4ms to 12ms] OR +1.21% [0.59% to 1.84%]
clearItems2End phase estimated improvement -21ms [-22ms to -19ms] OR -24.79% [-26.51% to -22.68%]
render5000Items1End phase estimated improvement -27ms [-37ms to -16ms] OR -0.84% [-1.18% to -0.51%]
clearManyItems1End phase estimated regression +2ms [0ms to 4ms] OR +0.7% [0% to 1.37%]
render5000Items2End phase no difference [-18ms to 1ms]
clearManyItems2End phase no difference [0ms to 1ms]
render1000Items3End phase no difference [-9ms to 1ms]
append1000Items1End phase no difference [-4ms to 15ms]
append1000Items2End phase no difference [-8ms to 9ms]
updateEvery10thItem1End phase estimated regression +6ms [1ms to 12ms] OR +1.54% [0.25% to 2.85%]
updateEvery10thItem2End phase no difference [0ms to 16ms]
selectFirstRow1End phase no difference [0ms to 0ms]
selectSecondRow1End phase no difference [0ms to 1ms]
removeFirstRow1End phase no difference [-1ms to 0ms]
removeSecondRow1End phase no difference [0ms to 0ms]
swapRows1End phase no difference [0ms to 0ms]
swapRows2End phase no difference [0ms to 0ms]
clearItems4End phase no difference [-1ms to 2ms]
paint phase no difference [0ms to 0ms]

[08:55:54] Generating Benchmark Reports [started]
[08:56:02] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

@lifeart
Copy link
Owner Author

lifeart commented Jan 19, 2025

will be landed as part of #195

@lifeart lifeart closed this Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant