Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow each without block params #86

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

lifeart
Copy link
Owner

@lifeart lifeart commented Feb 2, 2024

splitting changes from #25

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for g-next ready!

Name Link
🔨 Latest commit 0443204
🔍 Latest deploy log https://app.netlify.com/sites/g-next/deploys/65bcbb20dfe85b00081969fc
😎 Deploy Preview https://deploy-preview-86--g-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 2, 2024

Code Coverage Report

Coverage after merging allow-each-without-block-params into master

76.38%
Coverage Report
FileLines (%)Funcs (%)Uncovered Lines
.../pages/page-one
   Smile.ts71.436, 7, 8, 9, ...
.../pages/page-two
   Clock.ts94.2983.3318, 27
tests
   utils.ts95.5629, 73, 74, 75, ...
utils
   benchmark.ts69.4419, 20, 21, 22, ...
   compat.ts96.2328, 29, 30, 38, ...
   component.ts96.7079, 8, 9, 97, ...
   dom-api.ts95.6512, 21, 22, 23, ...
   dom.ts98.3492.11783, 786, 798, 877, ...
   ember-inspector.ts14.70096, 97, 98, 99, ...
   if.ts59.8366.6796, 97, 98, 99, ...
   list.ts93.448066, 70, 71, 72, ...
   reactive.ts99.3066, 67, 85, 86, ...
   rehydration-dom-api.ts5096, 97, 98, 99, ...
   rehydration.ts135, 144
   runtime.ts11
   shared.ts76.7095, 96, 97, 98, ...
   vm.ts24, 4
utils/helpers
   hash.ts81.8266.6714, 15, 16, 17, ...
   if.ts66.672, 3, 4
utils/inspector
   index.ts33.33096, 97, 98, 99, ...

@lifeart lifeart marked this pull request as ready for review February 2, 2024 09:53
@lifeart lifeart merged commit 46cf081 into master Feb 2, 2024
8 checks passed
@lifeart lifeart deleted the allow-each-without-block-params branch February 2, 2024 09:53
Copy link

github-actions bot commented Feb 2, 2024

duration phase no difference [-66ms to 213ms]
renderEnd phase estimated improvement -1ms [-1ms to 0ms] OR -2.03% [-4.09% to -0.31%]
render1000Items1End phase no difference [-12ms to 7ms]
clearItems1End phase no difference [0ms to 7ms]
render1000Items2End phase no difference [-14ms to 3ms]
clearItems2End phase no difference [0ms to 1ms]
render5000Items1End phase no difference [-1ms to 63ms]
clearManyItems1End phase no difference [-1ms to 4ms]
render5000Items2End phase no difference [-16ms to 33ms]
clearManyItems2End phase no difference [0ms to 8ms]
render1000Items3End phase no difference [-15ms to 17ms]
append1000Items1End phase no difference [-13ms to 26ms]
append1000Items2End phase no difference [-35ms to 16ms]
updateEvery10thItem1End phase no difference [-1ms to 1ms]
updateEvery10thItem2End phase no difference [-14ms to 15ms]
selectFirstRow1End phase no difference [0ms to 6ms]
selectSecondRow1End phase no difference [0ms to 0ms]
removeFirstRow1End phase no difference [0ms to 0ms]
removeSecondRow1End phase no difference [0ms to 0ms]
swapRows1End phase no difference [0ms to 15ms]
swapRows2End phase no difference [-1ms to 0ms]
clearItems4End phase estimated regression +3ms [0ms to 6ms] OR +1.38% [0.14% to 2.52%]
paint phase no difference [0ms to 0ms]

[10:38:41] Generating Benchmark Reports [started]
[10:38:46] Generating Benchmark Reports [completed]

Benchmark Reports    

JSON: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/compare.json

PDF: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.pdf

HTML: /home/runner/work/glimmer-next/glimmer-next/tracerbench-results/artifact-1.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant