Avoid ESM failures when AWS V4 signing is unused #176
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alpha does not work well in a non-ESM because Axios, upstream, adopted ESM in their "unsafe" published source files. This sort of failure is common when adopting the latest Alpha version:
Luckily, the only place that "unsafe" (aka ESM) modules are imported is in the AWS V4 signing support and that is very infrequently used. By making this change, it reduces the failure to only modules that use AWS V4 (nearly nobody and they must already have to deal with it)
This change doesn't avoid the problem completely, but it significantly reduces the impact.