bug: fix json tag

[longhutianjie]

Change Description

fix json tag

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

• Your PR passes all CI checks.
• Tests covering the positive and negative (error paths) are included.
• Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

• The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
• Commits follow the Ideal Git Commit Structure.
• Any new logging statements use an appropriate subsystem and logging level.
• Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
• There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our Contribution Guidelines for further guidance.

[coderabbitai]

Important

Review skipped

Auto reviews are limited to specific labels.

Labels to auto review (1)

• llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[guggero]

Thanks for the fix. Looks like the code isn't actually used for parsing JSON, otherwise this would've failed...

[Sajjon]

@guggero @ellemouton

Caution

GH user longhutianjie is performing a supply chain attack!
🚫 BLOCK user immediatly and report him to Github 🚫

The first step is getting rid of "first time contributor" status.

The user has manually added the message "Signed-off-by: " to make the commit
look more trust worthy. User has opened similar PRs in all these other
repos in within the same hour:

• FIX: fix shutdownCancelProfitOrders json tag c9s/bbgo#1731
• chore: remove repetitive words crypto-org-chain/cronos#1566
• chore: remove repetitive words ethereumclassic/ethereumclassic.github.io#1579
• chore: remove repetitive words stellar/go#5453
• chore: remove redundant logic ory/hydra#3831
• chore: use fommat function dfinity/ic#1309
• bug: fix json tag #9064
• chore: remove repetitive words near/nearcore#12036
• chore: fix some comments stellar/stellar-core#4450
• chore(core): fix some comments fetchai/uAgents#525
• bug: fix slice init length vitessio/vitess#16708

Furthermore I'm pretty sure this is the same person or group as github.com/vivoxfold3,
who tried performing the attack against these repos, with the exact same style:
Manually adding the message "Signed-off-by: " and making trivial contributions
to many crypto libs within the same hour:

• chore: remove repetitive words radixdlt/babylon-wallet-ios#1321
• chore: fix some comments DeFiCh/ain#3031
• chore: fix some comments beefyfinance/beefy-api#1546
• chore: fix typo for README.md fluencelabs/cli#1022
• chore: remove repetitive words hoprnet/hoprnet#6482
• bug: fix width name ResearchHub/researchhub-web#1825
• chore: fix some comments Taraxa-project/taraxa-node#2846

[guggero]

@Sajjon thanks for the warning. We get a lot of these drive-by "contributions", though usually it's because there's a financial incentive somewhere (either they get some form of crypto token as rewards for open source contributions or participate in events like "Google Summer of Code" or similar).
Is there anything specific that makes you classify this as a malicious attack or preparation for one?

@longhutianjie any response to this accusation from your end? And make sure your response doesn't sound like AI generated BS...

[Sajjon]

@Sajjon thanks for the warning. We get a lot of these drive-by "contributions", though usually it's because there's a financial incentive somewhere (either they get some form of crypto token as rewards for open source contributions or participate in events like "Google Summer of Code" or similar). Is there anything specific that makes you classify this as a malicious attack or preparation for one?

@guggero This is the second GH user which:

1. has no sources (only forks)
2. no profile photo
3. no followers
4. no bio
5. forks ~10 crypto libs or repos used by crypto libs / wallets all within the same hour
6. makes trivial contributions and tries to "falsify" a GPG signature by writing "Signed off by"
7. ignores PR templates

The exact same behaviour was done by GH use vivoxfold3 also last week, which responded using... hmm... interesting phrasing:

hoprnet/hoprnet#6482 (comment)

"Unreasonable accusations from persecuted delusional patients"

Whatever that means? Obvious bad translation service.

Point 6) is a specifically strong indication - imagine you have not actually setup signing of git commits (GPG or SSH key) - what do you do if you are an honest actor? Well you don't sign right... Here user is trying to make commit look serious by appending the string "Signed Off by" - which I see user did not do in this PR, most have forgotten, but did in crypto-org-chain/cronos@00c1941, and in ethereumclassic/ethereumclassic.github.io@0461042

[guggero]

Thank you for your response. Unfortunately 1-4 and 7 are quite common for those drive-by PRs.
But I agree that 5 and 6 together look quite suspicious.

Though it looks like they updated their behavior? Since the commit in this PR was signed with 62EAB0072D19DF1C.

Probably a good idea to block those users, I agree.