Return (potentially) partial buffers on error. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, servers will response with an error, and then immediately close the connection. In those cases, we can still recover some information to be parsed for better error handling downstream. One notable example is rate limiting. The current behaviour makes it appear to be a connection issue (connection reset by peer). However, if we inspect the buffer, we notice a rate limiting message. If we in turn pass this to the whoisparser, we can treat it like other generic rate limiting errors, and act accordingly.
|
An alternative solution:
It felt like it overlaps a bit with the |
|
Hello @mfycheng If you think this repository is helpful, please share it with friends, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, servers will response with an error, and then immediately close the connection. In those cases, we can still recover some information to be parsed for better error handling downstream.
One notable example is rate limiting. The current behaviour makes it appear to be a connection issue (connection reset by peer). However, if we inspect the buffer, we notice a rate limiting message. If we in turn pass this to the whoisparser, we can treat it like other generic rate limiting errors, and act accordingly.