Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add WhoisContext and use context for all queries #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

babariviere
Copy link

Close #39

This implementation will keep the same implementation as before.

There is only one breaking change if someone was calling client.SetDialer which now requires a dialer with a context.

@babariviere
Copy link
Author

@likexian If you want me to preserve the SetDialer API, I can wrap the dialer without context in a dialer that ignore the context but I don't think that's a good idea and I don't know of a better one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace timeouts with ctx
1 participant