Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove 'xserver' prefix from displayManager.sessionPackages #64

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

atagen
Copy link
Contributor

@atagen atagen commented Apr 12, 2024

Hello, and thank you for this repo!

Without changing anything beyond a nix flake update, today I got this while trying to rebuild:

       error: The option `services.xserver.displayManager.sessionPackages' does not exist. Definition values:
       - In `/nix/store/z0pdqcm1ywkha41a95khs6qa3bwr3yki-source/nixos/cosmic/module.nix':
           {
             _type = "if";
             condition = true;
             content = [
               <derivation cosmic-session-0-unstable-2024-04-08>
           ...

per this discussion and commit it appears the correct syntax is now without xserver, much as the cosmic module itself uses desktopManager/displayManager without xserver prefix.

I assume most people using this will be tracking unstable, as I am - unfortunately I'm not aware of a way to satisfy both stable and unstable users right now.

@atagen
Copy link
Contributor Author

atagen commented Apr 12, 2024

nvm, just saw in another issue that this repo only works with unstable, so should be fine

Copy link
Owner

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much!

@lilyinstarlight
Copy link
Owner

I'll merge this when rebuilds finish, thanks again :)
(It could be a while given it looks like the channel bump rebuilds all cosmic apps...)

@lilyinstarlight lilyinstarlight merged commit 788c275 into lilyinstarlight:main Apr 12, 2024
2 checks passed
lilyinstarlight added a commit that referenced this pull request Apr 12, 2024
* remove 'xserver' prefix from displayManager.sessionPackages

* flake: update inputs

---------

Co-authored-by: atagen <atagen@boss.co>
Co-authored-by: Lily Foster <lily@lily.flowers>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants