allow to execute one test multiple times with different parameters #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ipmb Could you please check this PR? |
|
I think the list of tuples format should be the default. We can keep |
PetrDlouhy
force-pushed
the
multi_test
branch
2 times, most recently
from
327d5e5
to
59d6850
Compare
|
@ipmb Thanks for the comment. I have transformed the code, so that list of tuples is default. Dict now throws deprecated warning. I have also added test for the old behavior. I had to move All tests should pass when you pull #14 |
|
@ipmb Is everything OK with this PR or should I make some more effort? |
|
It's all good. I hope we can merge it soon... just doing some housekeeping to make this easier in the future. |
dchukhin
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to perform the
check_cachetest on all of my caches so I modified the code to allow set/array inALIVE_CHECKSsettings.