fix: validateEvent on webhook

line · Mar 12, 2024 · 9cef74a · 9cef74a
1 parent 4a2bac5
commit 9cef74a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/apps/api/src/domains/admin/project/webhook/webhook.service.ts b/apps/api/src/domains/admin/project/webhook/webhook.service.ts
@@ -61,7 +61,7 @@ export class WebhookService {
         EventTypeEnum.ISSUE_STATUS_CHANGE,
       ].includes(event.type)
     ) {
-      return !event.channelIds;
+      return !event.channelIds || event.channelIds.length === 0;
     }
 
     return false;
@@ -103,11 +103,6 @@ export class WebhookService {
     });
 
     return await this.repository.save(newWebhook);
-
-    // const savedEvents = await this.eventRepo.save(events);
-    // savedWebhook.events = savedEvents;
-
-    // return savedWebhook;
   }
 
   async findById(webhookId: number) {

diff --git a/apps/api/src/domains/admin/statistics/feedback-issue/feedback-issue-statistics.service.ts b/apps/api/src/domains/admin/statistics/feedback-issue/feedback-issue-statistics.service.ts
@@ -116,7 +116,9 @@ export class FeedbackIssueStatisticsService {
       where: { id: projectId },
     });
     const timezoneOffset = timezone.offset;
+
     const cronHour = (24 - Number(timezoneOffset.split(':')[0])) % 24;
+
     const job = new CronJob(`2 ${cronHour} * * *`, async () => {
       if (
         await this.schedulerLockService.acquireLock(