Rename TxAuthGenericAlg to TxAuthGenericArg
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Aashay-Chapatwala
approved these changes
Dec 13, 2023
|
@pinzolo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Rename to
TxAuthGenericArgfromTxAuthGenericAlg.Overview or reasons
Looking at the spec, Web Authentication: An API for accessing Public Key Credentials Level 1 -> 10.3. Generic Transaction Authorization Extension (txAuthGeneric), I think
TxAuthGenericAlgis simply typo.Tasks
Renamed with IntelliJ's refactoring feature.
Result
Successfully renamed.
Since
Algis not included in the JSON property name, it has no effect on the external integration.