Correct the capitalisation of the png tag
#740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See googlefonts/fontations#1167 (comment) Co-Authored-By: Laurenz Stampfl <47084093+LaurenzV@users.noreply.github.com>
Philipp-M
approved these changes
Nov 22, 2024
| @@ -162,7 +162,7 @@ impl<'a> BitmapStrike<'a> { | |||
| match &self.0 { | |||
| StrikeKind::Sbix(sbix, metrics) => { | |||
| let glyph = sbix.glyph_data(glyph_id).ok()??; | |||
| if glyph.graphic_type() != Tag::new(b"PNG ") { | |||
| if glyph.graphic_type() != Tag::new(b"png ") { | |||
There was a problem hiding this comment.
It would be nice to note some provenance for this tag. Perhaps https://developer.apple.com/fonts/TrueType-Reference-Manual/RM06/Chap6sbix.html
There was a problem hiding this comment.
The canonical form of this code doesn't live here; I've intentionally touched it as little as possible. Instead, it can be found at https://github.com/googlefonts/fontations/blob/skrifa-bitmaps/skrifa/src/bitmap.rs.
The place to record this feedback is probably in the first linked issue in the PR.
|
(I think we need a lot more provenance links in general!) |
|
This needs a changelog entry. |
DJMcNab
added a commit
to DJMcNab/vello
that referenced
this pull request
Nov 22, 2024
If I would evaluate the CHANGELOG before the next release, I would reach the decision that linebender#740 doesn't need a changelog entry However, @waywardmonkeys believes that it does, so the only viable way for this to end up in the changelog is to do it now
Merged
DJMcNab
added a commit
to DJMcNab/vello
that referenced
this pull request
Nov 22, 2024
If I would evaluate the CHANGELOG before the next release, I would reach the decision that linebender#740 doesn't need a changelog entry However, @waywardmonkeys believes that it does, so the only viable way for this to end up in the changelog is to do it now
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 24, 2024
If I would evaluate the CHANGELOG before the next release, I would reach the decision that #740 doesn't need a changelog entry However, @waywardmonkeys believes that it does, so the only viable way for this to end up in the changelog is to do it now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See googlefonts/fontations#1167 (comment)
Should make linebender/xilem#420 work.