xilem_core: Refactor Memoization (add Frozen view, fix force-rebuild in Arc, and cleanup Memoize)
#451
Conversation
xilem_core/src/views/memoize.rs
Outdated
| } | ||
|
|
||
| /// Specialized version of [`memoize`], which doesn't take any data at all, the closure is evaluated only once and when a child view forces a rebuild | ||
| pub fn static_view<State, Action, Context, Message, V, InitView>( |
There was a problem hiding this comment.
I thought against this in Bevy, and I'm going to fight against this here; we do not want components to have names ending in _view .
I know that we can't use static because that's a keyword. Maybe eternal works?
There was a problem hiding this comment.
eternal sounds epic at least^^ Yeah I'm also not happy with static_view ideal would be static or something. Though eternal probably suggests that this will live forever...
There was a problem hiding this comment.
static also suggests it will live forever. We definitely can't end up in a state where this is _view 😅
There was a problem hiding this comment.
Also true... Yeah finding good names is hard, probably the hardest thing in programming^^ I'll try to think about it, but I agree, we should remove _view.
There was a problem hiding this comment.
Hmm, what about frozen? I've pushed that for now. Other ideas were fixed, immutable invariant (so of course still open for discussion).
There was a problem hiding this comment.
I like frozen and immutable.
fixed reminds me more of positioning like in CSS position: fixed
xilem_core/src/views/memoize.rs
Outdated
| phantom: PhantomData<fn() -> (State, Action)>, | ||
| } | ||
|
|
||
| /// Specialized version of [`memoize`], which doesn't take any data at all, the closure is evaluated only once and when a child view forces a rebuild |
There was a problem hiding this comment.
We should explain this in terms of why you would use it, not in reference to any other value.
There was a problem hiding this comment.
Probably skim again, I also added an example doc-comment for Memoize
Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
Philipp-M
changed the title
Static view, fix force-rebuild in Arc, and cleanup Memoize)Frozen view, fix force-rebuild in Arc, and cleanup Memoize)
This adds a
forcewhich is basically a specializedMemoizewithout any bound data.This also cleans up
Memoizea little bit (mostly code-aesthetic stuff, but also addsStateandActionparams to the view, so that it doesn't offer weird surprises when composing it with views likeAdapt).The
Arcview is also fixed, as it didn't support force rebuilding yet, which is relevant for e.g. async, e.g. theMemoizedAwaitview would not work inside anArc<impl View>currently.