Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BoxConstraints::min #651

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove BoxConstraints::min #651

wants to merge 2 commits into from

Conversation

PoignardAzur
Copy link
Contributor

I'll probably break this into multiple PRs at some point. This creates a lot of snapshot test errors.

@jaredoconnell
Copy link
Contributor

This is what happened to the calc example:
image

With min removed, we're going to need to add the RequestedSize enum to the layout calls. That will allow us to account for the case where min is currently used. Basically just tell it to fill the space instead of use the min size.

When I get a chance I'll experiment with that route and if I come up with something useful I'll submit a PR.

@PoignardAzur
Copy link
Contributor Author

I'd rather have an "expand" attribute on the button itself, if we go that route. I still don't like the idea of telling a widget "you need to be at least / exactly this size".

But yeah, these examples need to get un-broken before this can get out of draft.

@PoignardAzur
Copy link
Contributor Author

For the record, I think the way to go is to split this PR into multiple chunks. So first we might call loosen() in a bunch of places where we currently pass tight constraints, and see which errors pop up. Then once roughly all constraints we pass are loose, we can remove the mix parameter without disruption.

@jaredoconnell
Copy link
Contributor

I'm currently experimenting with replacing BoxConstraints itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants