Add passthrough code #714
Open
Add passthrough code #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
reviewed
Oct 23, 2024
| /// Whether this widgets obstructs pointer events for something behind the window. | ||
| /// | ||
| /// Somewhat experimental. | ||
| fn is_passthrough(&self) -> bool { |
There was a problem hiding this comment.
What's the semantic difference between this and accepts_pointer_interaction?
There was a problem hiding this comment.
is_passthrough doesn't affect children.
There's probably a way to design these features to be more orthogonal and principled, but this is meant to be a quick-and-easy fix.
| @@ -325,6 +326,28 @@ impl RenderRoot { | |||
| self.cursor_icon | |||
| } | |||
|
|
|||
| pub fn is_passthrough(&self, pos: PhysicalPosition<f64>) -> bool { | |||
There was a problem hiding this comment.
This needs a doc comment.
| @@ -325,6 +326,28 @@ impl RenderRoot { | |||
| self.cursor_icon | |||
| } | |||
|
|
|||
| pub fn is_passthrough(&self, pos: PhysicalPosition<f64>) -> bool { | |||
| let pos = Vec2::new(pos.x, pos.y) / self.scale_factor; | |||
There was a problem hiding this comment.
Would be nice if we were just using dpi::LogicalPosition here.
| @@ -199,6 +199,13 @@ pub trait Widget: AsAny { | |||
| false | |||
| } | |||
|
|
|||
| /// Whether this widgets obstructs pointer events for something behind the window. | |||
There was a problem hiding this comment.
I'd add a pointer back to the RenderRoot method and the doc comment that will be there which can contain the more complete explanation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code should help people who want to embed Masonry in a video game UI.