Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xilem_web: Fix todomvc example (items left in footer) #773

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

Philipp-M
Copy link
Contributor

Previously the complete count of todo items were shown, but only active (i.e. non-completed) todos should be considered in the count.
In the original todomvc implementation (e.g. react), I haven't found the <strong> node as well, so that is just combined as a single text node.

@Philipp-M Philipp-M changed the title xilem_web: Fix todomvc exmaple (items left in footer) xilem_web: Fix todomvc example (items left in footer) Dec 6, 2024
@Philipp-M Philipp-M added this pull request to the merge queue Dec 7, 2024
Merged via the queue into linebender:main with commit ebc25ca Dec 7, 2024
17 checks passed
@Philipp-M Philipp-M deleted the xilem_web-fix-todomvc branch December 7, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants