Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xilem_web: Add open and save file example #780

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

flosse
Copy link
Contributor

@flosse flosse commented Dec 9, 2024

No description provided.

@flosse flosse added the web label Dec 9, 2024
@flosse flosse requested a review from Philipp-M December 9, 2024 17:07
@DJMcNab
Copy link
Member

DJMcNab commented Dec 9, 2024

I think that calling this upload is quite misleading, as it strongly suggests that there is a server involved. I'd normally say open/save are probably the equivalents for local files, noting that the save operation as you have to implement it on the web is much closer semantically to download.

@flosse flosse changed the title xilem_web: Add up- and download example xilem_web: Add open and save file example Dec 9, 2024
@flosse
Copy link
Contributor Author

flosse commented Dec 9, 2024

I think that calling this upload is quite misleading, as it strongly suggests that there is a server involved.

Well, I guess it depends on the perspective, but I understand your point of course.

I'd normally say open/save are probably the equivalents for local files, noting that the save operation as you have to implement it on the web is much closer semantically to download.

I am totally open to the naming 😄

I have now renamed it to open/save.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants