Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix run_single_update_pass to avoid crashes #834

Merged
merged 1 commit into from
Jan 19, 2025
Merged

Fix run_single_update_pass to avoid crashes #834

merged 1 commit into from
Jan 19, 2025

Conversation

PoignardAzur
Copy link
Contributor

No description provided.

This was referenced Jan 18, 2025
Merged
Merged
waywardmonkeys
waywardmonkeys reviewed Jan 18, 2025
View reviewed changes
Copy link
Contributor

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something where there could be a test to ensure it doesn’t regress?

@PoignardAzur
Copy link
Contributor Author

There should probably be one, yes.

jaredoconnell
jaredoconnell approved these changes Jan 19, 2025
View reviewed changes
Copy link
Contributor

@jaredoconnell jaredoconnell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes the problem I found on my branch. This is also a code improvement. Less duplication.
Adding a test to catch regressions would be a good idea.

@PoignardAzur PoignardAzur added this pull request to the merge queue Jan 19, 2025
@PoignardAzur
Copy link
Contributor Author

Leaving tests for later, sorry.

Merged via the queue into main with commit d09c588 Jan 19, 2025
17 checks passed
@PoignardAzur PoignardAzur deleted the fix_has_hovered branch January 19, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys left review comments

@jaredoconnell jaredoconnell jaredoconnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PoignardAzur @waywardmonkeys @jaredoconnell